docs: Update SafeRollout concept doc based on new availability trackers#1088
Merged
britaniar merged 3 commits intoAzure:mainfrom Mar 20, 2025
Merged
docs: Update SafeRollout concept doc based on new availability trackers#1088britaniar merged 3 commits intoAzure:mainfrom
britaniar merged 3 commits intoAzure:mainfrom
Conversation
britaniar
changed the title
jwtty
reviewed
Mar 18, 2025
|
|
||
| #### Custom Resource Definition | ||
| For `CustomResourceDefinition` availability is determined as follows: | ||
| - Condition `Established` is set to true. |
Contributor
There was a problem hiding this comment.
Are these two conditions an "AND" relation or "OR" relation? Other cases are all "OR" relation.
jwtty
reviewed
Mar 19, 2025
| `UnavailablePeriodSeconds` is used to configure the waiting time between rollout phases when we cannot determine if the | ||
| resources have rolled out successfully or not. This field is used only if the availability of resources we propagate | ||
| are not trackable. Refer to the [Data only object](#data-only-objects) section for more details. | ||
| are not trackable. Refer to the [How It Works](#how-it-works) section for more details on a list of resources we can track. |
Contributor
There was a problem hiding this comment.
I guess this should be "Availability based Rollout" on line 179?
jwtty
approved these changes
Mar 20, 2025
ryanzhang-oss
pushed a commit
to ryanzhang-oss/fleet
that referenced
this pull request
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have: updated SafeRollout concept doc based on new availability trackers
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer